Add ReflectionProperty::isDynamic()
#4292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Dec 13, 2024
Comment on lines
66
to
72
| &reftitle.seealso; | ||
| <para> | ||
| <simplelist> | ||
| <member><methodname>ReflectionProperty::getValue</methodname></member> | ||
| </simplelist> | ||
| </para> | ||
| </refsect1> |
There was a problem hiding this comment.
Suggested change
| &reftitle.seealso; | |
| <para> | |
| <simplelist> | |
| <member><methodname>ReflectionProperty::getValue</methodname></member> | |
| </simplelist> | |
| </para> | |
| </refsect1> | |
| &reftitle.seealso; | |
| <simplelist> | |
| <member><methodname>ReflectionProperty::getValue</methodname></member> | |
| </simplelist> | |
| </refsect1> |
Comment on lines
+41
to
+45
| class Foo { | ||
| public $bar; | ||
| } |
There was a problem hiding this comment.
You need to add the dynamic property attribute to the class, otherwise a deprecation notice would be in the output
There was a problem hiding this comment.
Alright, also added to isDefault() then
Comment on lines
+16
to
+17
| Checks whether the property was declared at run-time, or whether the | ||
| property was declared at compile-time. |
There was a problem hiding this comment.
Not sure about this wording, maybe something like:
Checks whetehr the property was declared at run-time,
or if the property is declared in a class at compile time.
? But I still not amazed by my wording.
There was a problem hiding this comment.
I actually used the same wording as isDefault(), if it matters.
alexandre-daubois
force-pushed
the
dynamic-props
branch
from
be4d9f6 to
5f08ad4
Compare
Girgias
approved these changes
Dec 21, 2024
|
FYI: This PR forgot to adjust versions.xml. I've fixed that in f8fc16d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3872