Allow FPM_LOG_BUFFER to be adjusted in conf file, changed the buffer to be dynamically allocated #18328
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WektorPriv
changed the title
|
@bukka could you please take a look if it's even valid approach, and If yes what steps should I perform next? |
|
Hi, thanks for giving it a try. However it will require a bit different implementation. The idea is to use the same logger as for stdio (zlog) - it will require some changes there but it should give us more robust and performant implementation. |
|
@bukka, can we then bump the limit to 2048 temporarely and then work on the refactor? Logs in system I am working on are truncated. My options to optimize log format to fit 1024 characters are pretty limited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix issue #12302.