-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Do not use RTLD_DEEPBIND if dlmopen is available #18612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danog
wants to merge
19
commits into
php:master
Choose a base branch
from
danog:disable_deepbind_use_dlmopen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16
−1
Open
Changes from 5 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
fe18f08
Do not use RTLD_DEEPBIND if dlmopen is available
danog ced06f8
Re-enable RTLD_DEEPBIND when on apache for a different reason
danog 5919d0b
Use a sapi config instead
danog e4297b0
Add missing include
danog d8bb1aa
CS
danog fe761cc
Add missing includes
danog 9f749bc
Fix
danog 8292577
Switch to flags
danog 7d59f7c
Remove unneeded SAPI include
danog a21c3e4
Revert "Remove unneeded SAPI include"
danog c527785
Bump
danog f368a31
Merge remote-tracking branch 'origin/master' into disable_deepbind_us…
danog 680a887
Cleanup
danog 77a3e9d
Test
danog 990316e
Fixup
danog 2892cbd
Test
danog b6c6e5d
Fix typo
danog 8051d71
Refactor
danog 91e58d0
Merge remote-tracking branch 'origin/master' into disable_deepbind_us…
danog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ | |
|
||
#include "zend_extensions.h" | ||
#include "zend_system_id.h" | ||
#include "SAPI.h" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You still have this include, but I don't understand why you still need this? |
||
|
||
ZEND_API zend_llist zend_extensions; | ||
ZEND_API uint32_t zend_extension_flags = 0; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.