Skip to content

[BUGFIX] Check error level is higher #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

[BUGFIX] Check error level is higher #1233

merged 1 commit into from
Jun 24, 2025

Conversation

jaapio
Copy link
Member

@jaapio jaapio commented Jun 24, 2025

When the error level is set to warning on the spy errors should also be found as fail.

@jaapio jaapio requested a review from linawolf June 24, 2025 19:00
When the error level is set to warning on the spy errors should
also be found as fail.
@jaapio jaapio force-pushed the fix/error-reporting branch from 5263b43 to 0207ce4 Compare June 24, 2025 19:19
Copy link
Contributor

@linawolf linawolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, we can even reduce the phpstan baseline and you included tests.

@jaapio jaapio merged commit 85345ac into main Jun 24, 2025
49 checks passed
@jaapio jaapio deleted the fix/error-reporting branch June 24, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants