RoundFunctionReturnTypeExtension supports types with ConstantScalar #3349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shio3001
changed the title
Shio3001
force-pushed
the
feature/add-type-round-function
branch
from
465733b to
276f471
Compare
|
which problem does this change solve? whats your real world use-case? |
zonuexe
reviewed
Aug 26, 2024
| } | ||
|
|
||
| if (count($returnValueTypes) >= 1) { | ||
| return TypeCombinator::union(...array_map(static fn ($l) => $l, $returnValueTypes)); |
There was a problem hiding this comment.
Suggested change
| return TypeCombinator::union(...array_map(static fn ($l) => $l, $returnValueTypes)); | |
| return TypeCombinator::union(...$returnValueTypes); |
|
I'm sure there are several use cases for this, but one I quickly spotted in my private code is the following pattern, which uses Ideally it would be even more useful if a float range type was implemented, but I feel like this is worthwhile enough on its own. const MAX = 1000;
const PER_PAGE = 30;
$last_page = (int)floor(MAX / PER_PAGE); |
Shio3001
force-pushed
the
feature/add-type-round-function
branch
from
98e7404 to
e4ad097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns a constant when
$numparameter and option of the round function are constants.In this case , the conventional type is returned.
$numparameter is a numeric string.$numparameter union contains a numeric string.round()option is not a constant.