Fix "Named arguments are supported only on PHP 8.0 and later." false positive #4032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the underlying problem is, that we remember PHP_VERSION_ID when narrowing and therefore fallback to a wrong scope-state. see the scope-dump before/after the IF in this snippet: my current fix is wrong though |
|
This pull request has been marked as ready for review. |
staabm
commented
May 28, 2025
| @@ -34,6 +34,8 @@ | |||
| final class ConstantResolver | |||
| { | |||
|
|
|||
| public const PHP_MIN_ANALYZABLE_VERSION_ID = 50207; | |||
There was a problem hiding this comment.
this constant might need a better name. couldn't come up with something better.
|
the remaining failing tests are the same ones as in another just rebased PR of mine, therefore I think the errors are not related to this PR |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running https://phpstan.org/r/8df32644-1f4b-4b46-934d-5134753fbd47 in a codebase outside of phpstan-src did not reproduce the error
putting the reproducer under
CallMethodsRuleTestdid also not reproduce the error, asignore-by-php-version.neon.phpis not loaded in the test-suite