Skip to content

Update note RE: Blank passwords #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

Update note RE: Blank passwords #1778

merged 1 commit into from
Mar 20, 2025

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Addresses #1764

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from a team March 4, 2025 19:24
yubiuser
yubiuser approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also be more explicit at https://docs.pi-hole.net/docker/configuration/

@PromoFaux
Copy link
Member Author

Good shout RE: Docs, will keep this PR unmerged as a reminder

PromoFaux added a commit to pi-hole/docs that referenced this pull request Mar 20, 2025
@PromoFaux
Include note from pi-hole/docker-pi-hole#1778
075daf1 
Signed-off-by: Adam Warner <[email protected]>
@PromoFaux PromoFaux merged commit c1c9eec into master Mar 20, 2025
6 checks passed
@PromoFaux PromoFaux deleted the PromoFaux-patch-1 branch March 20, 2025 17:23
@PromoFaux PromoFaux mentioned this pull request Mar 20, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubiuser yubiuser yubiuser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PromoFaux @yubiuser