-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upstream: support ticdc topology info in tidb dashboard #1209
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
pkg/upstream/upstream.go:358
- The use of 'clientV3.WithLease' here may not be compatible with the updated etcd.Client interface. Consider using the corresponding lease option provided by the new etcd client wrapper to ensure consistency.
_, err = up.etcdCli.Put(ctx, key, string(value), clientV3.WithLease(up.session.Lease()))
pkg/upstream/manager.go:31
- The comment refers to 'CaptureTopologyCfg' while the actual type is named 'NodeTopologyCfg'. Consider updating the comment to match the type name for clarity.
// CaptureTopologyCfg stores the information of the capture topology.
/check-issue-triage-complete |
Does it conflict with the old TiCDC? |
@wlwilliamx: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #1115
What is changed and how it works?
This PR adds support for showing TiCDC cluster node information in the TiDB Dashboard. It works by writing each TiCDC node’s topology info into etcd under the key
/topology/ticdc/{clusterID}/{ip:port}
. The data includes basic node metadata and is registered with a lease so it gets cleaned up automatically if the node goes down.The TiDB Dashboard can read from the
/topology/ticdc/
prefix, parse the values, and display the list of active TiCDC nodes along with their details. This helps users get a better view of the CDC cluster status directly from the dashboard without needing to query it separately.Related code in
tidb-dashboard
repo: https://github.com/pingcap/tidb-dashboard/blob/release-9.0-beta.1/pkg/utils/topology/ticdc.go#L22.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note