planner: fix doesn't push down hash join to tiflash #60436
+198
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #60436 +/- ##
================================================
+ Coverage 73.0851% 73.5364% +0.4512%
================================================
Files 1715 1715
Lines 475095 475355 +260
================================================
+ Hits 347224 349559 +2335
+ Misses 106494 104411 -2083
- Partials 21377 21385 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ti-chi-bot
bot
removed
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
labels
|
/retest |
hawkingrei
requested review from
Copilot and
AilinKid
and removed request for
Copilot
There was a problem hiding this comment.
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (3)
- pkg/planner/core/casetest/tpch/BUILD.bazel: Language not supported
- pkg/planner/core/casetest/tpch/testdata/tpch_suite_in.json: Language not supported
- pkg/planner/core/casetest/tpch/testdata/tpch_suite_out.json: Language not supported
|
/retest |
|
/retest |
winoros
reviewed
Apr 11, 2025
winoros
reviewed
Apr 11, 2025
|
/retest |
ti-chi-bot
bot
added
size/XXL
|
/retest |
1 similar comment
|
/retest |
|
/retest |
hawkingrei
force-pushed
the
tpch_q9
branch
2 times, most recently
from
20161ee to
dd48c63
Compare
|
/retest |
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
winoros
approved these changes
Apr 16, 2025
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
winoros
reviewed
Apr 16, 2025
AilinKid
approved these changes
Apr 17, 2025
| func (p *PhysicalHashJoin) enforceExchangerByBackup(task *MppTask, idx int, expectedCols int) *MppTask { | ||
| if backupHashProp := p.GetChildReqProps(idx); backupHashProp != nil { | ||
| if len(backupHashProp.MPPPartitionCols) == expectedCols { | ||
| return task.enforceExchangerImpl(backupHashProp) |
There was a problem hiding this comment.
It seems we first eliminate the ex and add it back if necessary. i afraid the complicated case, currently looks fine to me
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #60407
Problem Summary:
What changed and how does it work?
caused by #57417
because
NeedMPPExchangeByEquivalencewill change the hash partitioning information. Having different numbers of MPP partitions in the child nodes of a join can lead to invalid tasks, which ultimately result in incorrect plan.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.