Skip to content

Remove accidental request-1.json commit #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove accidental request-1.json commit #735

wants to merge 2 commits into from

Conversation

cholmes
Copy link
Member

@cholmes cholmes commented Oct 31, 2022

Didn't mean to actually add that one in - apologies.

@kevinlacaille kevinlacaille added this to the 2.0b1: Core 'MVP' milestone Oct 31, 2022
@kevinlacaille kevinlacaille self-requested a review October 31, 2022 22:13
kevinlacaille
kevinlacaille approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@kevinlacaille kevinlacaille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for changing the CLI tutorial for the new request functionality (ie. item_type and bundle are now arguments). I do ask that you change your title and PR description as this PR is an update of the CLI tutorial, not a removal of a JSON file.

@cholmes
Copy link
Member Author

cholmes commented Oct 31, 2022

Something went wrong in this one. Closing and making a new one...

@cholmes cholmes closed this Oct 31, 2022
@cholmes cholmes deleted the remove-request-json branch November 17, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlacaille kevinlacaille kevinlacaille approved these changes

Assignees

@cholmes cholmes

Labels
documentation
Projects
None yet
Milestone
2.0b1: Core 'MVP'
Development

Successfully merging this pull request may close these issues.
2 participants
@cholmes @kevinlacaille