Skip to content

Svg improvements, also more verbose images-test page #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

jensens
Copy link
Member

@jensens jensens commented Sep 8, 2022

need merged and tested with/after merge of plone/plone.scale#68

@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jensens
Copy link
Member Author

jensens commented Apr 4, 2025

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Member

I have released plone.scale 4.2.0 which has the method that you added there. I have updated 6.0/1/2-dev on dist.plone.org.

Meanwhile Jenkins tests fail with:

Unicode strings with encoding declaration are not supported. Please use bytes input or XML fragments without declaration.

@jensens jensens force-pushed the svg-improvements branch from 68bf74b to f964aea Compare April 7, 2025 11:30
@jensens
Copy link
Member Author

jensens commented Apr 7, 2025

@jenkins-plone-org please run jobs

@jensens jensens marked this pull request as ready for review April 7, 2025 11:36
@jensens jensens requested a review from mauritsvanrees April 7, 2025 11:36
@jensens
Copy link
Member Author

jensens commented Apr 7, 2025

@mauritsvanrees all green now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants