Skip to content

Use npm v7 and node.js 16 in development and testing #5922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 3, 2021
Merged

Use npm v7 and node.js 16 in development and testing #5922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c342824
use node.js v16 and npm v7
archmoj Sep 3, 2021
6a755b7
list all i.e. npm v7 option similar to npm v6 default
archmoj Sep 3, 2021
00251d6
npm i updated package-lock - integrity keys added to forks
archmoj Sep 3, 2021
988d9b7
add noCI flag to one test
archmoj Sep 3, 2021
6a169bc
adjust pie test
archmoj Sep 3, 2021
8702f96
update log for PR 5922
archmoj Sep 3, 2021
d59c041
mention upgrade of package-lock in the PR log
archmoj Sep 3, 2021
1211ac9
list production dependencies similar to preversion and do not bypass …
archmoj Sep 3, 2021
d00ea0e
run no-new-func test when building for new version
archmoj Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ version: 2.0
jobs:
install-and-cibuild:
docker:
- image: circleci/node:14.17.5
- image: circleci/node:16.8.0
working_directory: ~/plotly.js
steps:
- checkout
Expand All @@ -34,7 +34,7 @@ jobs:
timezone-jasmine:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:14.17.5-browsers
- image: circleci/node:16.8.0-browsers
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
no-gl-jasmine:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:14.17.5-browsers
- image: circleci/node:16.8.0-browsers
environment:
# Alaska time (arbitrary timezone to test date logic)
TZ: "America/Anchorage"
Expand All @@ -79,7 +79,7 @@ jobs:
webgl-jasmine:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:14.17.5-browsers
- image: circleci/node:16.8.0-browsers
environment:
# Alaska time (arbitrary timezone to test date logic)
TZ: "America/Anchorage"
Expand All @@ -95,7 +95,7 @@ jobs:
flaky-no-gl-jasmine:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:14.17.5-browsers
- image: circleci/node:16.8.0-browsers
environment:
# Alaska time (arbitrary timezone to test date logic)
TZ: "America/Anchorage"
Expand All @@ -110,7 +110,7 @@ jobs:
bundle-jasmine:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:14.17.5-browsers
- image: circleci/node:16.8.0-browsers
environment:
# Alaska time (arbitrary timezone to test date logic)
TZ: "America/Anchorage"
Expand Down Expand Up @@ -143,7 +143,7 @@ jobs:

test-baselines:
docker:
- image: circleci/node:14.17.5
- image: circleci/node:16.8.0
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand Down Expand Up @@ -178,7 +178,7 @@ jobs:

test-exports:
docker:
- image: circleci/node:14.17.5
- image: circleci/node:16.8.0
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand All @@ -192,7 +192,7 @@ jobs:

mock-validation:
docker:
- image: circleci/node:14.17.5
- image: circleci/node:16.8.0
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand All @@ -206,7 +206,7 @@ jobs:

source-syntax:
docker:
- image: circleci/node:14.17.5
- image: circleci/node:16.8.0
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand All @@ -217,7 +217,7 @@ jobs:

publish-dist:
docker:
- image: circleci/node:14.17.5
- image: circleci/node:16.8.0
working_directory: ~/plotly.js
steps:
- checkout
Expand Down
2 changes: 1 addition & 1 deletion .circleci/env_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ export NODE_OPTIONS='--max-old-space-size=4096' && \
echo "node version: $(node --version)" && \
echo "npm version: $(npm --version)" && \
npm ci && \
npm ls || true
npm ls --prod --all
2 changes: 1 addition & 1 deletion draftlogs/5919_change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
- Use node.js v14 in tests and publishing [[#5919](https://github.com/plotly/plotly.js/pull/5919)]
- Use `node.js v16` and `npm v7` in development and upgrade version of `package-lock.json` [[#5922](https://github.com/plotly/plotly.js/pull/5922), [#5919](https://github.com/plotly/plotly.js/pull/5919)]
Loading