Skip to content

Make sure that perceptuallyCompare fails if Metal is not available #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make sure that perceptuallyCompare fails if Metal is not available #702

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2615ad
make sure that `perceptuallyCompare` fails if Metal is not available
mschuetz-viz Jan 31, 2023
1a1dd38
Merge branch 'main' into main
Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Sources/SnapshotTesting/Snapshotting/UIImage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,10 @@ import MetalPerformanceShaders

@available(iOS 10.0, tvOS 10.0, macOS 10.13, *)
func perceptuallyCompare(_ old: CIImage, _ new: CIImage, pixelPrecision: Float, perceptualPrecision: Float) -> String? {
guard nil != MTLCreateSystemDefaultDevice() else {
return "Failed to compare snapshots. Metal is required for perceptuallyCompare, but not available on this machine."
}

let deltaOutputImage = old.applyingFilter("CILabDeltaE", parameters: ["inputImage2": new])
let thresholdOutputImage: CIImage
do {
Expand Down