Skip to content

Upgrade dependencies #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Upgrade dependencies #478

wants to merge 1 commit into from

Conversation

timsueberkrueb
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
test/test-runner/src/index.rs 90.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
test/test-runner/src/index.rs 98.63% <90.00%> (-1.37%) ⬇️

@timsueberkrueb
Copy link
Collaborator Author

Somehow this added a dependency on home which doesn't compile on wasm.

@BinderDavid
Copy link
Collaborator

We should also use the common workspace Cargo.toml file for specifying the version of url and this-error.

@BinderDavid
Copy link
Collaborator

Where do you see a problem with WASM? I only see the following in the MSRV action:

 error: rustc 1.80.1 is not supported by the following package:
  [email protected] requires rustc 1.81

@timsueberkrueb
Copy link
Collaborator Author

Where do you see a problem with WASM? I only see the following in the MSRV action:

This doesn't show up in ci until it's merged in main (which is another thing we should fix). cd web and make run will reproduce the problem locally, though.

@BinderDavid
Copy link
Collaborator

Cp. rust-lang/cargo#12297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants