New Add a Pallet Tutorial with Nicks Pallet #627
Conversation
danforbes
commented
Aug 20, 2020
danforbes
commented
- Updates and refactors to Start a Chain and Build a dApp tutorials.
- New Add a Pallet tutorial that uses Nicks pallet.
- Rename existing Add a Pallet tutorial to Add the Contracts Pallet
danforbes
requested review from
jimmychu0807,
wheresaddie,
JoshOrndorff and
riusricardo
|
I'm not sure why CI is reporting that the links are broken... |
danforbes
force-pushed
the
df-tuts-rework
branch
3 times, most recently
from
6e78ea7 to
64e696d
Compare
danforbes
force-pushed
the
df-tuts-rework
branch
from
64e696d to
85ee96b
Compare
| If we look at the Nicks pallet in detail, we know it has: | ||
|
|
||
| - Module **Storage**: Because it uses the `decl_storage!` macro. | ||
| - Module **Event**s: Because it uses the `decl_event!` macro. |
There was a problem hiding this comment.
Worth mentioning that the Events have type parameters based on the configuration trait so we will use Event<T>?
If you don't like eplaining that level of detail this early on, maybe at least acknowledge it and say learners will understand it later?
The
<T>on the end ofEvent<T>has to do with generic type parameters. That's beyond the scope of this tutorial, but just know it needs to be there for now.
danforbes
force-pushed
the
df-tuts-rework
branch
from
85ee96b to
beb3257
Compare
|
@JoshOrndorff thanks for the great review. Please pay special attention to the following commits: |
|
Nice updates. Now double approved. |
|
Oh, I see its still a draft. |
|
My bad...just took it out of draft. That was just a leftover. |
|
This addressed polkadot-developers/tutorials#17 |
