Skip to content

add support for sqlserver #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion src/preset_cli/cli/superset/sync/dbt/lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ def build_sqlalchemy_params(target: Dict[str, Any]) -> Dict[str, Any]:
return build_bigquery_sqlalchemy_params(target)
if type_ == "snowflake":
return build_snowflake_sqlalchemy_params(target)

if type_ == "sqlserver":
return build_sqlserver_sqlalchemy_params(target)
raise NotImplementedError(
f"Unable to build a SQLAlchemy URI for a target of type {type_}. Please file an "
"issue at https://github.com/preset-io/backend-sdk/issues/new?labels=enhancement&"
Expand Down Expand Up @@ -198,6 +199,37 @@ def build_snowflake_sqlalchemy_params(target: Dict[str, Any]) -> Dict[str, Any]:
return parameters


def build_sqlserver_sqlalchemy_params(target: Dict[str, Any]) -> Dict[str, Any]:
windows_login = target.get("windows_login", None)
username = target.get("user", None)
password = target.get("password", "") or None
database = target["database"]
server = target["server"]
port = target["port"]
driver = target.get("driver")
encrypt = target.get("encrypt", False)
trust_cert = target.get("trust_cert", False)
assert windows_login or (username and password), "Either windows login or user+password has to be defined for mssql"

connection_string = f"DRIVER={{{driver}}};SERVER={server};DATABASE={database};PORT={port};"
if windows_login:
connection_string += "Integrated Security=SSPI;Trusted_Connection=yes;"
else:
connection_string += f"UID={username};PWD={password};"
if encrypt:
connection_string += "Encrypt=yes;"
if trust_cert:
connection_string += "TrustServerCertificate=yes;"

return {
"sqlalchemy_uri": str(
URL.create(
'mssql+pyodbc',
query={"odbc_connect": connection_string})
),
}


def env_var(var: str, default: Optional[str] = None) -> str:
"""
Simplified version of dbt's ``env_var``.
Expand Down