-
Notifications
You must be signed in to change notification settings - Fork 59
feat: garble vm #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: garble vm #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, nice abstractions 🚀 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
I left some qs, including security-critical ones.
@sinui0
// | ||
// Only prove MACs for output data and evaluator's inputs. | ||
let provable_input = match self.role { | ||
Role::Generator => input - self.vis.visible(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why this not input.intersection(self.vis.blind())
like above?
* adjust block lsb and ops * feat: garble vm * fix test * remove redundant test
* adjust block lsb and ops * feat: garble vm * fix test * remove redundant test
* adjust block lsb and ops * feat: garble vm * fix test * remove redundant test
This PR implements a semi-honest GC VM, including a lot of the core functionality which can be applied to implement the coming quicksilver VM.