Skip to content

feat: garble vm #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 9, 2024
Merged

feat: garble vm #191

merged 4 commits into from
Nov 9, 2024

Conversation

sinui0
Copy link
Collaborator

@sinui0 sinui0 commented Nov 3, 2024

This PR implements a semi-honest GC VM, including a lot of the core functionality which can be applied to implement the coming quicksilver VM.

@sinui0 sinui0 requested review from themighty1 and th4s November 3, 2024 20:41
This was referenced Nov 3, 2024
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, nice abstractions 🚀 🚀

@sinui0 sinui0 merged commit 50828d7 into alpha.1 Nov 9, 2024
@sinui0 sinui0 deleted the feat/garble-vm branch November 9, 2024 06:37
Copy link
Collaborator

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.
I left some qs, including security-critical ones.
@sinui0

//
// Only prove MACs for output data and evaluator's inputs.
let provable_input = match self.role {
Role::Generator => input - self.vis.visible(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this not input.intersection(self.vis.blind()) like above?

sinui0 added a commit that referenced this pull request Mar 3, 2025
* adjust block lsb and ops

* feat: garble vm

* fix test

* remove redundant test
sinui0 added a commit that referenced this pull request Mar 3, 2025
* adjust block lsb and ops

* feat: garble vm

* fix test

* remove redundant test
nakkstar123 pushed a commit to nakkstar123/mpz that referenced this pull request Apr 5, 2025
* adjust block lsb and ops

* feat: garble vm

* fix test

* remove redundant test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants