make metadata tests compatible with batch parameter #314
+34
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're updating the spec to add a batch parameter to metadata. This makes the tests compatible with both versions of the spec for now; eventually we'll update Ergo and the Unreal module to match the new spec, at which point we can make the batch parameter a hard requirement.
slingamn
added a commit
to slingamn/ergo
that referenced
this pull request
Jun 22, 2025
This is progval/irctest#314 but I don't want to couple the merges
slingamn
added a commit
to ergochat/ergo
that referenced
this pull request
Jun 22, 2025
* spec update: metadata keys are lowercase * add batch parameter to metadata batches * fix: connecting clients receive METADATA, not RPL_KEYVALUE * spec update: send RPL_METADATASUBS in a metadata-subs batch * move some helpers * bump irctest to forked hash This is progval/irctest#314 but I don't want to couple the merges * fix: empty value is valid * fix: deleting a nonexistent key gets a FAIL
progval
reviewed
Jun 23, 2025
Comment on lines
+27
to
31
| # TODO: s/ANYOPTSTR/ANYSTR/, as per spec update to require a batch parameter | ||
| # indicating the target | ||
| self.assertMessageMatch( | ||
| first_msg, command="BATCH", params=[StrRe(r"\+.*"), "metadata"] | ||
| first_msg, command="BATCH", params=[StrRe(r"\+.*"), "metadata", ANYOPTSTR] | ||
| ) |
There was a problem hiding this comment.
Make the caller pass the expected target name, and match with OptStrRe(re.escape(target))
There was a problem hiding this comment.
This is kind of painful because we can't make an Either optional AFAICT. It'll be easier to do after we make the parameter mandatory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're updating the spec to add a batch parameter to metadata. This makes the tests compatible with both versions of the spec for now; eventually we'll update Ergo and the Unreal module to match the new spec, at which point we can make the batch parameter a hard requirement.