Skip to content

iis: Add HTTP Service Request Queues #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SSanjeevi
Copy link

Add HTTP Service Request Queues

What this PR does / why we need it

Add HTTP Service Request Queues for IIS

Which issue this PR fixes

@SSanjeevi SSanjeevi requested a review from a team as a code owner March 20, 2025 14:57
Copy link
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please crease a new sub-collector for HTTP Service Request Queues

@SSanjeevi SSanjeevi requested a review from jkroepke March 21, 2025 12:47
@jkroepke jkroepke changed the title Add HTTP Service Request Queues iss: Add HTTP Service Request Queues Mar 21, 2025
@jkroepke jkroepke changed the title iss: Add HTTP Service Request Queues iis: Add HTTP Service Request Queues Mar 21, 2025
@jkroepke
Copy link
Member

HI,

please run Get-Counter -Counter "\HTTP Service Request Queues(*)\CurrentQueueSize", I would like to see some examples.

Secondly, I'm not sure, if the site label is correct. Are the counter reports sites or app pool?

lastly, Please extend the documentations. https://github.com/prometheus-community/windows_exporter/blob/master/docs/collector.iis.md

And take care of CI please.

@SSanjeevi
Copy link
Author

SSanjeevi commented Mar 22, 2025

HI,

please run Get-Counter -Counter "\HTTP Service Request Queues(*)\CurrentQueueSize", I would like to see some examples.

Secondly, I'm not sure, if the site label is correct. Are the counter reports sites or app pool?

lastly, Please extend the documentations. https://github.com/prometheus-community/windows_exporter/blob/master/docs/collector.iis.md

And take care of CI please.

image
It gives apppool and some additional items with serial numbers

what can we use now?

atleast it uses apppool - then can you pls suggest where to change what?

@jkroepke
Copy link
Member

I have zero knowledge about IIS. But the numbers are documented. It seems there are request which cant match to an pool.

ref: https://stackoverflow.com/questions/71599831/http-service-request-queues-currentqueuesize-counter-instance-name

Maybe you understand, what going on here?

@SSanjeevi
Copy link
Author

I have zero knowledge about IIS. But the numbers are documented. It seems there are request which cant match to an pool.

ref: https://stackoverflow.com/questions/71599831/http-service-request-queues-currentqueuesize-counter-instance-name

Maybe you understand, what going on here?

They are saying sometime it will not be mapped to apppool, so lets have apppool as filter but get all metrics from http request queue and one with flterable apppool others as it is.
To do this what can i make change in my PR?

@jkroepke
Copy link
Member

jkroepke commented May 1, 2025

Hi @SSanjeevi once I got access to an IIS VM, i will also looked into this closer. It's not staled, but without an test environment, I'm a bit stuck right now.

@SSanjeevi
Copy link
Author

Hi @SSanjeevi once I got access to an IIS VM, i will also looked into this closer. It's not staled, but without an test environment, I'm a bit stuck right now.

If you have any Windows system - you can enable IIS and test it out.
https://jotelulu.com/en-gb/support/tutorials/how-to-install-iis-on-windows-10/

@jkroepke
Copy link
Member

jkroepke commented May 2, 2025

If you have any Windows system

At the moment, i have just an Mac. And I would not like to install the IIS on the gaming box. Since the Mac is an ARM CPU, I can't run Windows inside a VM.

Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
@jkroepke
Copy link
Member

@SSanjeevi Finally I found an environment to test this PR. I fxied some issues. So please let me know if it works on your side as well.

@SSanjeevi
Copy link
Author

@SSanjeevi Finally I found an environment to test this PR. I fxied some issues. So please let me know if it works on your side as well.

looks good pls proceed - share me installable version i can test it.

@jkroepke
Copy link
Member

@SSanjeevi
Copy link
Author

https://github.com/prometheus-community/windows_exporter/actions/runs/15226529252/artifacts/3190334509

@jkroepke - it's failing to run in windows system and no error log in event viewer. Only log exist was an starting exporter

@SSanjeevi
Copy link
Author

can you pls share build step to generate artifact locally? so that i will build and fix the issue.

@jkroepke
Copy link
Member

Download go: https://go.dev/doc/install

Run

go build -o windows_exporter.exe ./cmd/windows_exporter/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is "HTTP Service Request Queues" metric for IIS Available?
2 participants