web/landing_page: Add option to disable profiling links #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrueg
force-pushed
the
disable-profiling-links
branch
from
d7baf88 to
b38f772
Compare
Signed-off-by: Manuel Rüger <[email protected]>
mrueg
force-pushed
the
disable-profiling-links
branch
from
b38f772 to
40e54fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you don't want to show links to pprof endpoints on the landingpage because they run on a different port.
This rather should be a bool, but then it gets more complicated to make it backwards compatible (as the unset bool will default to false).
Another option would be to make this option negative like "DisablePProfLinks" or similar, then a bool will work.