This repository was archived by the owner on May 19, 2023. It is now read-only.
Simplify code #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2022
|
@AlexWayfer answering your question, this PR is here to test Electron 19. The final version will try to use a different native fuzzy finder, and maybe merge atom#152 too because it seems interesting |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Fuzzy-Finder uses THREE different libraries to make filtering. One of them use Native Bindings, which are not context-aware.
So, we either must decide on using a single one, or migrate to Zadeh (the move I actually want to work later).
I'm drafting this PR so this change does not get lost somewhere :)