Addiing in zookeeper example, fixes #159 #1790
Conversation
rshade
force-pushed
the
rshade/zookeeper
branch
2 times, most recently
from
01c0583 to
36282ac
Compare
rshade
force-pushed
the
rshade/zookeeper
branch
from
36282ac to
c064d74
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new example setup for deploying a ZooKeeper cluster on AWS using Pulumi in TypeScript. The key changes include a complete cloud infrastructure configuration (VPC, security groups, IAM roles, launch template, auto scaling group, and load balancer), an accompanying README with deployment instructions, and a Pulumi project file.
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| aws-ts-zookeeper/index.ts | Implements the AWS infrastructure and configuration for ZooKeeper. |
| aws-ts-zookeeper/README.md | Provides documentation and setup instructions for the ZooKeeper cluster. |
| aws-ts-zookeeper/Pulumi.yaml | Defines the Pulumi project configuration and runtime details. |
Files not reviewed (3)
- aws-ts-zookeeper/.gitignore: Language not supported
- aws-ts-zookeeper/package.json: Language not supported
- aws-ts-zookeeper/tsconfig.json: Language not supported
| volumeSize: 50, | ||
| volumeType: "gp3", | ||
| deleteOnTermination: "true", | ||
| encrypted: "true", |
There was a problem hiding this comment.
The 'encrypted' property for the EBS volume is set as a string instead of a boolean. Consider updating it to use a boolean value (true) to match the expected type.
| encrypted: "true", | |
| encrypted: true, |
Copilot uses AI. Check for mistakes.
| // Target Group | ||
| const targetGroup = new aws.lb.TargetGroup(`${projectName}-tg`, { | ||
| port: 2181, | ||
| protocol: "HTTP", |
There was a problem hiding this comment.
ZooKeeper typically uses TCP rather than HTTP. If the service does not support HTTP, update the target group protocol to 'TCP' or adjust the configuration accordingly.
| protocol: "HTTP", | |
| protocol: "TCP", |
Copilot uses AI. Check for mistakes.
This pull request includes several significant changes to set up a ZooKeeper cluster on AWS using Pulumi. The changes span multiple files, including configuration files, code for infrastructure setup, and documentation.
Key changes include:
Infrastructure Setup:
aws-ts-zookeeper/index.ts: Added comprehensive code to configure and deploy a ZooKeeper cluster on AWS. This includes setting up a VPC, security groups, IAM roles, instance profiles, launch templates, auto-scaling groups, load balancers, and CloudWatch monitoring.Configuration Files:
aws-ts-zookeeper/Pulumi.yaml: Added configuration details for the Pulumi project, specifying the project name, runtime, package manager, and a description of the project.aws-ts-zookeeper/package.json: Added package dependencies for Pulumi and AWS libraries required for the project.aws-ts-zookeeper/tsconfig.json: Added TypeScript configuration options, including strict type checking, output directory, and module resolution settings.Documentation:
aws-ts-zookeeper/README.md: Added detailed documentation on the components and features of the ZooKeeper cluster, as well as instructions for deployment.Gitignore:
aws-ts-zookeeper/.gitignore: Added entries to ignore thebindirectory andnode_modulesdirectory.