Skip to content

Migrate from purescript-dom #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

gabejohnson
Copy link

The purpose of this PR is to migrate the WebSocket code from purescript-dom to this repository.

@gabejohnson gabejohnson changed the title Everything Migrate from purescript-dom Aug 25, 2017
@gabejohnson
Copy link
Author

@natefaubion a couple of questions:

  1. Should I be creating a new effect for sockets?
  2. Since the namespacing has changed from DOM.Websocket to Web.Socket, should the type/function names change to follow suit? (WebSocket -> Socket, readWebSocket -> readSocket)

@JordanMartinez
Copy link
Contributor

Based on this comment and this response, I think this PR can be closed? It seems like the intent was to break web-related libraries out into smaller packages when v0.12.0 PS was released, and purescript-web-socket is it's own library now.

@thomashoneyman
Copy link
Contributor

thomashoneyman commented Sep 20, 2021

I believe this PR was superseded by c248be2, but please let me know if you’d prefer this be open @gabejohnson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants