Skip to content

Edit multiparam lesson #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2024
Merged

Edit multiparam lesson #67

merged 2 commits into from
Oct 23, 2024

Conversation

willingc
Copy link
Contributor

@willingc willingc commented Oct 23, 2024 •
edited
Loading

Closes #58.

  • Rename function to remove arr and make it more generalizable
  • correct parameter spacing when passing parameters there should be no spaces around the =

@willingc willingc requested a review from lwasser October 23, 2024 20:43
lwasser
lwasser approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. i think this lesson will also evolve over time but it's great to have it updated and rendering well now!! THANK YOU!!

@lwasser lwasser merged commit efefd62 into pyOpenSci:main Oct 23, 2024
4 checks passed
@willingc willingc deleted the edit-multiparam branch October 23, 2024 21:54
@sneakers-the-rat sneakers-the-rat mentioned this pull request Oct 23, 2024
Closed
@willingc willingc mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwasser lwasser lwasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

functions- multi parameters lesson needs to be cleaned up
2 participants
@willingc @lwasser