Fix compatibility with Pydantic 2.11 #1249
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
commented
Mar 26, 2025
| @@ -340,7 +340,7 @@ def _object_gen(self, schema: dict[str, Any]) -> dict[str, Any]: | |||
| add_prop_key += '_' | |||
| if addition_props is True: | |||
| data[add_prop_key] = self._char() | |||
| else: | |||
| elif addition_props is not False: | |||
There was a problem hiding this comment.
This is not strictly required but could fail at some point if not included.
Docs Preview
|
Viicos
commented
Mar 26, 2025
| @@ -397,6 +397,9 @@ def _get_python_type(cls, value: dict[str, Any]) -> str: | |||
| # 5) Object: Check for additionalProperties | |||
| if value_type == 'object': | |||
| additional_properties = value.get('additionalProperties', {}) | |||
| if isinstance(additional_properties, bool): | |||
There was a problem hiding this comment.
To have coverage, we need to upgrade to 2.11. Can I upgrade to the latest beta in this PR?
Draft
|
Will be handled in #1293. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per pydantic/pydantic#11392.