Skip to content

Tests for single bit compression #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CPBridge
Copy link
Contributor

@CPBridge CPBridge commented May 16, 2025

Describe the changes

Add/fix test files for the single bit compression pull request on pydicom main repo

The existing liver_nonbyte_aligned.dcm, that I previously added, is updated to fix the fact that when I created it by tweaking the liver.dcm file, I generated a new SOPInstanceUID but left the file metadata MediaStorageSOPInstanceUID at the old value. In this PR I bring the MediaStorageSOPInstanceUID in line with the SOPInstanceUID.

The following compressed single bit image test files are added. All are compressed versions of either liver.dcm or liver_nonbyte_aligned.dcm created using pydicom and the aforementioned branch:

  • liver_deflate.dcm
  • liver_nonbyte_aligned_deflate.dcm
  • liver_rle.dcm
  • liver_nonbyte_aligned_rle.dcm
  • liver_j2k.dcm
  • liver_nonbyte_aligned_j2k.dcm

(deflate = frame level deflate, j2k = JPEG2000Lossless, nonbyte_aligned = frames that are not a multiple of 8 pixels, which are an important special case for tests with single bit images due to bitpacking)

Tasks

  • In a branch on your fork of pydicom-data, add or modify data files
  • Create a pull request for pydicom-data
  • Update the commit hash for the urls in a fork/branch of the pydicom file [urls.json]https://github.com/pydicom/pydicom/blob/master/pydicom/data/urls.json and create a pydicom pull request
  • pydicom unit tests passing
  • [] Documentation updated (if needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant