Tests for single bit compression #16
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Add/fix test files for the single bit compression pull request on pydicom main repo
The existing
liver_nonbyte_aligned.dcm
, that I previously added, is updated to fix the fact that when I created it by tweaking theliver.dcm
file, I generated a new SOPInstanceUID but left the file metadata MediaStorageSOPInstanceUID at the old value. In this PR I bring the MediaStorageSOPInstanceUID in line with the SOPInstanceUID.The following compressed single bit image test files are added. All are compressed versions of either
liver.dcm
orliver_nonbyte_aligned.dcm
created using pydicom and the aforementioned branch:liver_deflate.dcm
liver_nonbyte_aligned_deflate.dcm
liver_rle.dcm
liver_nonbyte_aligned_rle.dcm
liver_j2k.dcm
liver_nonbyte_aligned_j2k.dcm
(
deflate
= frame level deflate,j2k
= JPEG2000Lossless,nonbyte_aligned
= frames that are not a multiple of 8 pixels, which are an important special case for tests with single bit images due to bitpacking)Tasks
[urls.json]https://github.com/pydicom/pydicom/blob/master/pydicom/data/urls.json
and create a pydicom pull request