refactor: pull out dependency_constraint #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeut
reviewed
Apr 5, 2025
mayeut
reviewed
Apr 5, 2025
mayeut
reviewed
Apr 5, 2025
mayeut
reviewed
Apr 5, 2025
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/refactor/depconst
branch
from
50605ed to
cbce985
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/refactor/depconst
branch
from
cbce985 to
6d7d94c
Compare
henryiii
commented
Apr 8, 2025
| @@ -27,7 +27,7 @@ jobs: | |||
| - bash: | | |||
| python -m pip install dependency-groups | |||
| python -m dependency_groups test | xargs python -m pip install -e. | |||
| python ./bin/run_tests.py --num-processes 2 | |||
| python ./bin/run_tests.py | |||
There was a problem hiding this comment.
This speeds up the macOS tests quite a bit. The docs say they have 3 cores, but 4 are reported. Either way, it's faster not to limit it. Also in #1538.
henryiii
commented
Apr 8, 2025
| @@ -7,7 +7,7 @@ pr: | |||
| jobs: | |||
| - job: linux_311 | |||
| timeoutInMinutes: 120 | |||
| pool: {vmImage: 'Ubuntu-20.04'} | |||
| pool: {vmImage: 'Ubuntu-22.04'} | |||
There was a problem hiding this comment.
20.04 is in brownout.
mayeut
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out from #2322 to simplify that one. Passes the actual Path or None instead of passing the flags and then parsing the argument back out (!). Also switches to using the URI, but I could do that in 2322 instead if there are any issues (edit: seems fine!).