-
Notifications
You must be signed in to change notification settings - Fork 264
Better help for GitHub Actions + Py27 workaround #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also see microsoft/setup-msbuild#13 - setup-msbuild is very specifically only a way to setup msbuild and not the rest of the env variables needed by distutils. |
Oops, sorry! I should have looked better, when adding that :-( Does this work better, perhaps? https://github.com/ilammy/msvc-dev-cmd |
Sorry, wanted to comment but misclicked... Was going to say I'd try myself, but I've not set up a GitHub Actions CI before, so it might be faster if you can try. |
I can test that, I'm writing up docs anyway. They do mention the idea of having a setup action in the issue above, but they don't have one yet. |
Great, thanks! I'm really baffled there seems to be no official way to "activate" Visual Studio in GitHub Actions? I also propose to maybe at the example code as a separate file to |
Here's the example snippet: - uses: ilammy/msvc-dev-cmd@v1
- name: Build 64-bit wheel
run: python -m cibuildwheel --output-dir wheelhouse
env:
CIBW_BUILD: cp27-win_amd64
DISTUTILS_USE_SDK: 1
MSSdk: 1
- uses: ilammy/msvc-dev-cmd@v1
with:
arch: x86
- name: Build 32-bit wheel
run: python -m cibuildwheel --output-dir wheelhouse
env:
CIBW_BUILD: cp27-win32
DISTUTILS_USE_SDK: 1
MSSdk: 1 Only saw a minimal example, so didn't change that. |
@joerick Good to merge, if it's up to me. But maybe you want to have a say on whether and how to include the example? |
This looks good - would it also be appropriate to include that snippet after the |
You mean the example snippet? I'd be happy to include it but wan't sure if it fit, since it's GHA only. Is there a way to access |
Added the snippet back in. |
One travis build stalled, feel free to restart (or ignore, since this is documentation only). |
Thank you @henryiii! |
Mentioned in #333 discussion.