Skip CI Test Run if diff with master doesn't touch code

[pradyunsg]

cf: #4478 (comment)

The CI Test runs take a long time. We should not run tests for PR builds which don't change any code.

Something similar that CPython does: https://github.com/python/cpython/blob/b405752dab95fa5dc65a19d94e798844d0378c61/.travis.yml#L88

[pradyunsg]

#5281 added these for Travis. Someone else will have to look into these for AppVeyor.

[pradyunsg]

AppVeyor has skip-commits.files. Making a PR that uses that.

https://www.appveyor.com/docs/how-to/filtering-commits/#skip-commits-2

[pradyunsg]

@pfmoore Could you look into skipping AppVeyor builds when there are no code changes? The skip-commits.files key doesn't help in this regard since we want a passing test.

I'm not familiar with Powershell (I solely used cmd+Sublime Text when I had a Windows machine).

[pfmoore]

Yep, I'll take a look.

[pfmoore]

@pradyunsg I've created #5643 which I think replicates the Travis logic. Could you take a look? I've tested it on a local toy repository, but I'm not entirely sure how best to check it against pip itself. Maybe you could do whatever you did when you tested the equivalent Travis change?

[pradyunsg]

I just ran it locally. I guess you could try it on your fork, if you're not very sure about it?

[pfmoore]

I'm pretty sure about it - I did a load of tests on a small repository of my own. But I don't really want to run the full pip test suite on Appveyor repeatedly to test this. On the plus side, it worked out that its own PR changed code and so ran the test suite correctly 😄

I'm not particularly that invested in the idea in any case (I see why we need it, but I'd rather we didn't have a test suite that took hours to run 😄) so if you think it's OK, I'll merge it once it passes CI, and if you could keep an eye on it after the fact that would be great.

[pradyunsg]

It looks okay. I keep an eye on the master CI anyway (I've broken it far too often :P) so, yeah, feel free to merge it.

[pradyunsg]

@pfmoore AppVeyor skipping for docs-only changes is awesome! ❤️

https://ci.appveyor.com/project/pypa/pip/build/1.0.3018

[pradyunsg]

We've got this now. Closing this issue.

[pfmoore]

@pradyunsg Glad it works well - I just ported the Travis code, so the credit goes there 😄

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.