Skip to content

Add the ability to short circuit CI builds for docs-only changes #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2018

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Apr 18, 2018

Partial resolution for #5185

Based on CPython's code, linked in the mentioned issue. This doesn't really help us with the news-only commits but this is an improvement regardless.

@pradyunsg pradyunsg added C: tests Testing and related things C: automation Automated checks, CI etc type: maintenance Related to Development and Maintenance Processes skip news Does not need a NEWS file entry (eg: trivial changes) labels Apr 18, 2018
@pradyunsg pradyunsg requested a review from pfmoore April 20, 2018 08:52
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in principle, but I don't really know enough about git(hub)/travis to comment on whether the implementation is correct. It looks OK to me, though.

@pradyunsg
Copy link
Member Author

@pfmoore Any chance you could look into something similar for Appveyor regarding this?

@pfmoore
Copy link
Member

pfmoore commented Apr 27, 2018

I'll try to. Snowed under with work & stuff at the moment, so may not be for a while...

@pradyunsg
Copy link
Member Author

No hurries. :)

I'll merge this one and keep the tracking issue open.

@pradyunsg pradyunsg merged commit daaa0fd into pypa:master Apr 28, 2018
@pradyunsg pradyunsg deleted the ci/short-circuiting branch April 28, 2018 06:24
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: automation Automated checks, CI etc C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants