Standardise link repr in logs #11083
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
reviewed
May 3, 2022
| @@ -170,7 +165,7 @@ def __call__( | |||
| logger.critical( | |||
| "HTTP error %s while getting %s", | |||
| e.response.status_code, | |||
| link, | |||
| link.show_url, | |||
There was a problem hiding this comment.
This should not be show_url but the entire URL.
There was a problem hiding this comment.
So its still inconsistent link repr in logs - as described in the issue
pradyunsg
reviewed
May 3, 2022
| url = str(link) | ||
| if logger.getEffectiveLevel() > logging.DEBUG: | ||
| url = link.show_url | ||
| meth("Could not fetch URL %s: %s - skipping", url, reason) |
There was a problem hiding this comment.
I don't think warnings/errors should present partial URLs, since its possible that the user has multiple indexes and needs to know which one the error is related to, without adding additional verbosity.
pradyunsg
reviewed
May 3, 2022
| else: | ||
| url = link.url_without_fragment | ||
|
|
||
| url = link.show_url |
There was a problem hiding this comment.
This is the only part of the change that I'm somewhat fine with, but I wonder if show_url should also mention the domain. That's something we can address in a follow up though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7390
ref: #10276 (comment)