-
Notifications
You must be signed in to change notification settings - Fork 3.1k
PEP 751 experimental pip lock
command
#13213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8c48ffb
Vendor tomli-w
sbidoul 4072aff
Add pip lock command (PEP 751)
sbidoul deb2713
lock: do not emit version for direct URLs
sbidoul 605f3b3
lock: use relativate paths for directories
sbidoul 2a331a3
lock: add --output
sbidoul 5f9005d
lock: update to latest PEP 751
sbidoul 50e85e3
lock: emit an experimental warning
sbidoul 2f5feef
lock: add documentation
sbidoul c04eae6
lock: add tests
sbidoul 8fb8996
lock: do not attempt to walk up when computing relative paths
sbidoul 5c7025d
lock: use canonical base dir to compute relavite directories
sbidoul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
|
||
.. _`pip lock`: | ||
|
||
======== | ||
pip lock | ||
======== | ||
|
||
|
||
|
||
Usage | ||
===== | ||
|
||
.. tab:: Unix/macOS | ||
|
||
.. pip-command-usage:: lock "python -m pip" | ||
|
||
.. tab:: Windows | ||
|
||
.. pip-command-usage:: lock "py -m pip" | ||
|
||
|
||
Description | ||
=========== | ||
|
||
.. pip-command-description:: lock | ||
|
||
Options | ||
======= | ||
|
||
.. pip-command-options:: lock | ||
|
||
.. pip-index-options:: lock | ||
|
||
|
||
Examples | ||
======== | ||
|
||
#. Emit a ``pylock.toml`` for the the project in the current directory | ||
|
||
.. tab:: Unix/macOS | ||
|
||
.. code-block:: shell | ||
|
||
python -m pip lock -e . | ||
|
||
.. tab:: Windows | ||
|
||
.. code-block:: shell | ||
|
||
py -m pip lock -e . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
:orphan: | ||
|
||
======== | ||
pip-lock | ||
======== | ||
|
||
Description | ||
*********** | ||
|
||
.. pip-command-description:: lock | ||
|
||
Usage | ||
***** | ||
|
||
.. pip-command-usage:: lock | ||
|
||
Options | ||
******* | ||
|
||
.. pip-command-options:: lock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Vendor tomli-w 1.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,171 @@ | ||
import sys | ||
from optparse import Values | ||
from pathlib import Path | ||
from typing import List | ||
|
||
from pip._internal.cache import WheelCache | ||
from pip._internal.cli import cmdoptions | ||
from pip._internal.cli.req_command import ( | ||
RequirementCommand, | ||
with_cleanup, | ||
) | ||
from pip._internal.cli.status_codes import SUCCESS | ||
from pip._internal.models.pylock import Pylock, is_valid_pylock_file_name | ||
from pip._internal.operations.build.build_tracker import get_build_tracker | ||
from pip._internal.req.req_install import ( | ||
check_legacy_setup_py_options, | ||
) | ||
from pip._internal.utils.logging import getLogger | ||
from pip._internal.utils.misc import ( | ||
get_pip_version, | ||
) | ||
from pip._internal.utils.temp_dir import TempDirectory | ||
|
||
logger = getLogger(__name__) | ||
|
||
|
||
class LockCommand(RequirementCommand): | ||
""" | ||
EXPERIMENTAL - Lock packages and their dependencies from: | ||
|
||
- PyPI (and other indexes) using requirement specifiers. | ||
- VCS project urls. | ||
- Local project directories. | ||
- Local or remote source archives. | ||
|
||
pip also supports locking from "requirements files", which provide an easy | ||
way to specify a whole environment to be installed. | ||
|
||
The generated lock file is only guaranteed to be valid for the current | ||
python version and platform. | ||
""" | ||
|
||
usage = """ | ||
%prog [options] [-e] <local project path> ... | ||
%prog [options] <requirement specifier> [package-index-options] ... | ||
%prog [options] -r <requirements file> [package-index-options] ... | ||
%prog [options] <archive url/path> ...""" | ||
|
||
def add_options(self) -> None: | ||
self.cmd_opts.add_option( | ||
cmdoptions.PipOption( | ||
"--output", | ||
"-o", | ||
dest="output_file", | ||
metavar="path", | ||
type="path", | ||
default="pylock.toml", | ||
help="Lock file name (default=pylock.toml). Use - for stdout.", | ||
) | ||
) | ||
self.cmd_opts.add_option(cmdoptions.requirements()) | ||
self.cmd_opts.add_option(cmdoptions.constraints()) | ||
self.cmd_opts.add_option(cmdoptions.no_deps()) | ||
self.cmd_opts.add_option(cmdoptions.pre()) | ||
|
||
self.cmd_opts.add_option(cmdoptions.editable()) | ||
|
||
self.cmd_opts.add_option(cmdoptions.src()) | ||
|
||
self.cmd_opts.add_option(cmdoptions.ignore_requires_python()) | ||
self.cmd_opts.add_option(cmdoptions.no_build_isolation()) | ||
self.cmd_opts.add_option(cmdoptions.use_pep517()) | ||
self.cmd_opts.add_option(cmdoptions.no_use_pep517()) | ||
self.cmd_opts.add_option(cmdoptions.check_build_deps()) | ||
|
||
self.cmd_opts.add_option(cmdoptions.config_settings()) | ||
|
||
self.cmd_opts.add_option(cmdoptions.no_binary()) | ||
self.cmd_opts.add_option(cmdoptions.only_binary()) | ||
self.cmd_opts.add_option(cmdoptions.prefer_binary()) | ||
self.cmd_opts.add_option(cmdoptions.require_hashes()) | ||
self.cmd_opts.add_option(cmdoptions.progress_bar()) | ||
|
||
index_opts = cmdoptions.make_option_group( | ||
cmdoptions.index_group, | ||
self.parser, | ||
) | ||
|
||
self.parser.insert_option_group(0, index_opts) | ||
self.parser.insert_option_group(0, self.cmd_opts) | ||
|
||
@with_cleanup | ||
def run(self, options: Values, args: List[str]) -> int: | ||
logger.verbose("Using %s", get_pip_version()) | ||
|
||
logger.warning( | ||
"pip lock is currently an experimental command. " | ||
"It may be removed/changed in a future release " | ||
"without prior warning." | ||
) | ||
|
||
session = self.get_default_session(options) | ||
|
||
finder = self._build_package_finder( | ||
options=options, | ||
session=session, | ||
ignore_requires_python=options.ignore_requires_python, | ||
) | ||
build_tracker = self.enter_context(get_build_tracker()) | ||
|
||
directory = TempDirectory( | ||
delete=not options.no_clean, | ||
kind="install", | ||
globally_managed=True, | ||
) | ||
|
||
reqs = self.get_requirements(args, options, finder, session) | ||
check_legacy_setup_py_options(options, reqs) | ||
|
||
wheel_cache = WheelCache(options.cache_dir) | ||
|
||
# Only when installing is it permitted to use PEP 660. | ||
# In other circumstances (pip wheel, pip download) we generate | ||
# regular (i.e. non editable) metadata and wheels. | ||
for req in reqs: | ||
req.permit_editable_wheels = True | ||
|
||
preparer = self.make_requirement_preparer( | ||
temp_build_dir=directory, | ||
options=options, | ||
build_tracker=build_tracker, | ||
session=session, | ||
finder=finder, | ||
use_user_site=False, | ||
verbosity=self.verbosity, | ||
) | ||
resolver = self.make_resolver( | ||
preparer=preparer, | ||
finder=finder, | ||
options=options, | ||
wheel_cache=wheel_cache, | ||
use_user_site=False, | ||
ignore_installed=True, | ||
ignore_requires_python=options.ignore_requires_python, | ||
upgrade_strategy="to-satisfy-only", | ||
use_pep517=options.use_pep517, | ||
) | ||
|
||
self.trace_basic_info(finder) | ||
|
||
requirement_set = resolver.resolve(reqs, check_supported_wheels=True) | ||
|
||
if options.output_file == "-": | ||
base_dir = Path.cwd() | ||
else: | ||
output_file_path = Path(options.output_file) | ||
if not is_valid_pylock_file_name(output_file_path): | ||
logger.warning( | ||
"%s is not a valid lock file name.", | ||
output_file_path, | ||
) | ||
base_dir = output_file_path.parent | ||
pylock_toml = Pylock.from_install_requirements( | ||
requirement_set.requirements.values(), base_dir=base_dir | ||
).as_toml() | ||
if options.output_file == "-": | ||
sys.stdout.write(pylock_toml) | ||
else: | ||
output_file_path.write_text(pylock_toml, encoding="utf-8") | ||
|
||
return SUCCESS |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@webknjaz we don't seem to have used that role in the pip documentation so far, so I'll leave that out for now. We can consider a separate PR to do that on a broader level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. FTR, Furo currently renders this role the same as regular inline code. Here's an example: https://packaging.python.org/en/latest/specifications/pyproject-toml/#pyproject-toml-license.