Skip to content

Mark launchpad test as flaky #13235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

notatallshaw
Copy link
Member

Should help with #13153

@notatallshaw
Copy link
Member Author

BTW, I'm not sure if test only PRs that have no user facing changes should have any kind of news item?

@notatallshaw notatallshaw added the skip news Does not need a NEWS file entry (eg: trivial changes) label Feb 23, 2025
@ichard26
Copy link
Member

Sadly, I don't think this will help. The test is already retried on CI due to the network marker and evidently those retries haven't been enough:

pip/tests/conftest.py

Lines 115 to 118 in ae1b526

if "CI" in os.environ:
# Mark network tests as flaky
if item.get_closest_marker("network") is not None:
item.add_marker(pytest.mark.flaky(reruns=3, reruns_delay=2))

@notatallshaw
Copy link
Member Author

Sadly, I don't think this will help. The test is already retried on CI due to the network marker and evidently those retries haven't been enough:

Okay, I think it's worth increasing the delay/retry count, if a retry can wait/try enough to complete it saves more time than rerunning a test. I'm going to open a new PR.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants