Skip to content

Add support for Android tags #13303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/13299.feature.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Support for :pep:`738` Android wheels.
13 changes: 13 additions & 0 deletions src/pip/_internal/utils/compatibility_tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from pip._vendor.packaging.tags import (
PythonVersion,
Tag,
android_platforms,
compatible_tags,
cpython_tags,
generic_tags,
Expand Down Expand Up @@ -63,6 +64,16 @@ def _ios_platforms(arch: str) -> List[str]:
return arches


def _android_platforms(arch: str) -> List[str]:
match = re.fullmatch(r"android_(\d+)_(.+)", arch)
if match:
api_level, abi = match.groups()
return list(android_platforms(int(api_level), abi))
else:
# arch pattern didn't match (?!)
return [arch]


def _custom_manylinux_platforms(arch: str) -> List[str]:
arches = [arch]
arch_prefix, arch_sep, arch_suffix = arch.partition("_")
Expand Down Expand Up @@ -90,6 +101,8 @@ def _get_custom_platforms(arch: str) -> List[str]:
arches = _mac_platforms(arch)
elif arch.startswith("ios"):
arches = _ios_platforms(arch)
elif arch_prefix == "android":
arches = _android_platforms(arch)
elif arch_prefix in ["manylinux2014", "manylinux2010"]:
arches = _custom_manylinux_platforms(arch)
else:
Expand Down
50 changes: 50 additions & 0 deletions tests/unit/test_models_wheel.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,56 @@ def test_not_supported_ios_version(self) -> None:
w = Wheel("simple-0.1-cp313-none-ios_15_1_arm64_iphoneos.whl")
assert not w.supported(tags=tags)

def test_android(self) -> None:
arm_old = compatibility_tags.get_supported(
"313", platforms=["android_21_arm64_v8a"], impl="cp"
)
arm_new = compatibility_tags.get_supported(
"313", platforms=["android_30_arm64_v8a"], impl="cp"
)
x86_old = compatibility_tags.get_supported(
"313", platforms=["android_21_x86_64"], impl="cp"
)
x86_new = compatibility_tags.get_supported(
"313", platforms=["android_30_x86_64"], impl="cp"
)

w = Wheel("simple-0.1-cp313-none-android_21_arm64_v8a.whl")
assert w.supported(arm_old)
assert w.supported(arm_new)
assert not w.supported(x86_old)
assert not w.supported(x86_new)

w = Wheel("simple-0.1-cp313-none-android_22_arm64_v8a.whl")
assert not w.supported(arm_old)
assert w.supported(arm_new)
assert not w.supported(x86_old)
assert not w.supported(x86_new)

w = Wheel("simple-0.1-cp313-none-android_31_arm64_v8a.whl")
assert not w.supported(arm_old)
assert not w.supported(arm_new)
assert not w.supported(x86_old)
assert not w.supported(x86_new)

w = Wheel("simple-0.1-cp313-none-android_20_x86_64.whl")
assert not w.supported(arm_old)
assert not w.supported(arm_new)
assert w.supported(x86_old)
assert w.supported(x86_new)

w = Wheel("simple-0.1-cp313-none-android_30_x86_64.whl")
assert not w.supported(arm_old)
assert not w.supported(arm_new)
assert not w.supported(x86_old)
assert w.supported(x86_new)

w = Wheel("simple-0.1-cp313-none-android_31_x86_64.whl")
assert not w.supported(arm_old)
assert not w.supported(arm_new)
assert not w.supported(x86_old)
assert not w.supported(x86_new)

def test_support_index_min(self) -> None:
"""
Test results from `support_index_min`
Expand Down