Warn when the pkg_resource metadata backend is used with Python 3.11, 3.12, 3.13 #13318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
commented
Apr 5, 2025
| if hasattr(importlib.metadata, "_PIP_USE_IMPORTLIB_METADATA"): | ||
| # The Python distributor has set the global constant, so we don't | ||
| # warn, since it is not a user decision. | ||
| return |
There was a problem hiding this comment.
I'm not entirely sure we should not warn the user here.
with Python 3.11, 3.12, 3.13.
sbidoul
force-pushed
the
deprecate-pkg-resources-backend
branch
from
98956d3 to
feef19f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #13317
We warn when the undocumented
_PIP_USE_IMPORTLIB_METADATAis set tofalse, causing the use of thepkg_resourcesmetadata backend on Python 3.11, 3.12, 3.13.