-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix pypy3 tests #4663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pypy3 tests #4663
Conversation
It would be great if the integration tests on Travis were a little bit more verbose: with the full testsuite taking so long, it's annoying to have to wait for it to end to be able to see the name of failed tests. If switching pytest verbose mode on is too much, maybe use pytest-sugar?:
|
I'm getting a failure locally with pypy3, in |
The issue with that is that the output is extremely long on running with xdist. I'm tempted to write a plugin for this but that's just a thought as of now... |
3fc4e00
to
f0e7e92
Compare
Fixed lint failures. |
Restarded the pypy/pypy3 jobs because they failed due to timeouts, and the pypy3 job failed again... |
I've re-triggered the pypy3 job now -- if it fails, I think someone would need to investigate what's causing the timeouts in more detail. |
It seems to me that tests are hitting pytest-dev/pytest#625? |
Yeah, there's definitely something fishy. I've restarted the job multiple times, no luck... It did pass on my repository Travis run, after 49 minutes! |
f0e7e92
to
8aea934
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on a first pass.
I think this can be closed now? |
Yeah. It got merged as a part of #4706 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The problem was the workaround for pypa/virtualenv#306: using
[...]/workspace/venv/lib-python/3.5
as the virtualenv lib directory when[...]/workspace/venv/lib-python/3
is the actual directory used when running with PyPy 3.