Skip to content

Fix pypy3 tests #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

benoit-pierre
Copy link
Member

The problem was the workaround for pypa/virtualenv#306: using [...]/workspace/venv/lib-python/3.5 as the virtualenv lib directory when [...]/workspace/venv/lib-python/3 is the actual directory used when running with PyPy 3.

@benoit-pierre
Copy link
Member Author

It would be great if the integration tests on Travis were a little bit more verbose: with the full testsuite taking so long, it's annoying to have to wait for it to end to be able to see the name of failed tests.

If switching pytest verbose mode on is too much, maybe use pytest-sugar?:

 tests/functional/test_install.py ⨯✓✓                      15% █▌
 tests/functional/test_hash.py ✓                           16% █▋
 tests/functional/test_install.py ✓✓                       16% █▋
 tests/functional/test_help.py ✓                           16% █▋
 tests/functional/test_install.py ✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓s✓     22% ██▎

@benoit-pierre
Copy link
Member Author

I'm getting a failure locally with pypy3, in test_pip_second_command_line_interface_works, but only when run with xdist... ¯\(ツ)

@pradyunsg
Copy link
Member

maybe use pytest-sugar?

The issue with that is that the output is extremely long on running with xdist. I'm tempted to write a plugin for this but that's just a thought as of now...

@benoit-pierre
Copy link
Member Author

Fixed lint failures.

@pradyunsg pradyunsg added C: automation Automated checks, CI etc type: maintenance Related to Development and Maintenance Processes project: pypy PyPy specific skip news Does not need a NEWS file entry (eg: trivial changes) labels Aug 10, 2017
@benoit-pierre
Copy link
Member Author

Restarded the pypy/pypy3 jobs because they failed due to timeouts, and the pypy3 job failed again...

@pradyunsg
Copy link
Member

I've re-triggered the pypy3 job now -- if it fails, I think someone would need to investigate what's causing the timeouts in more detail.

@pradyunsg
Copy link
Member

It seems to me that tests are hitting pytest-dev/pytest#625?

@benoit-pierre
Copy link
Member Author

Yeah, there's definitely something fishy. I've restarted the job multiple times, no luck... It did pass on my repository Travis run, after 49 minutes!

@benoit-pierre
Copy link
Member Author

@benoit-pierre
Copy link
Member Author

Rebased.

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on a first pass.

@dstufft
Copy link
Member

dstufft commented Sep 4, 2017

I think this can be closed now?

@pradyunsg pradyunsg closed this Sep 4, 2017
@pradyunsg
Copy link
Member

Yeah. It got merged as a part of #4706

@benoit-pierre benoit-pierre deleted the fix_pypy3_tests branch September 4, 2017 11:28
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: automation Automated checks, CI etc project: pypy PyPy specific skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants