Skip to content

Travis CI - Stages, Cleanup and magic #5450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 13, 2018
Merged

Travis CI - Stages, Cleanup and magic #5450

merged 3 commits into from
Jun 13, 2018

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented May 29, 2018 •
edited
Loading

Changes:

  • move non-install commands out of the travis_retry call
  • renamed "RUN_INSTALL_TESTS" to "GROUP"
  • removal of tox factors
  • auto-detection of tox's env from Travis's environment variables
  • addition of build stages (closes Travis flow optimization #5095)

@pradyunsg pradyunsg added skip news Does not need a NEWS file entry (eg: trivial changes) C: automation Automated checks, CI etc type: maintenance Related to Development and Maintenance Processes labels May 29, 2018
@pradyunsg
Copy link
Member Author

Whoops. The commits should be cleaned up.

pradyunsg added 2 commits May 30, 2018 00:44
@pradyunsg
Rework Travis CI configuration
1b07ea3 
- Use "group" terminology
- Remove tox factors
- Infer TOXENV from Travis environment (removes need to specify it)
@pradyunsg
Adopt Build Stages
c19f991
@pradyunsg pradyunsg force-pushed the misc/ci-stages-and-cleanup branch from d01ad8c to c19f991 Compare May 29, 2018 19:14
@pradyunsg
Copy link
Member Author

Cleaned up the commits. :)

@pradyunsg pradyunsg requested a review from a team May 29, 2018 19:15
@pradyunsg pradyunsg self-assigned this Jun 6, 2018
@pradyunsg
Copy link
Member Author

@pfmoore @dstufft Thoughts?

@pradyunsg
Copy link
Member Author

Latest Travis Build for this PR: https://travis-ci.org/pypa/pip/builds/385353504

  • 10 minute "primary" check
    • if any job at this stage fails, the build is marked as fail and stopped early.
  • 15 minute "secondary" check

@pfmoore
Copy link
Member

pfmoore commented Jun 6, 2018

I don't understand Travis in sufficient detail to comment, so I'll leave the decision to others. Sorry.

@pradyunsg
Copy link
Member Author

No issues. :)

I'm personally happy to merge as is, if no one minds.

@pradyunsg
Copy link
Member Author

Given that no one has raised any objections, I'll merge. :)

@pradyunsg pradyunsg merged commit caa0a17 into pypa:master Jun 13, 2018
@pradyunsg pradyunsg deleted the misc/ci-stages-and-cleanup branch June 13, 2018 15:09
@pradyunsg pradyunsg removed the request for review from a team June 13, 2018 15:09
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@pradyunsg pradyunsg

Labels
auto-locked Outdated issues that have been locked by automation C: automation Automated checks, CI etc skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Travis flow optimization
2 participants
@pradyunsg @pfmoore