Address issue #7280 with a WARNING rather than exception #7544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 30, 2019 18:21
- Try to delete the temporary directory, as most of the time this works - If it fails on windows due to an Access error, it clearly is not an Access error because we just created the directory. Warn the user and continue.
- Add issue description file
- Provide a class that manages a sub-process which can open a file and monkey with pip's abiliity to remove a file on windows. - This class can function as both a context manager and/or a pytest fixture.
- TempDirectory() tries to delete the directory as normal - if cleanup fails on Windows due to EACCES, warn about virus scanner - This is a more specific error than previous error, but does not change the behavior when a user is attempting to pip uninstall in a system directory - This changes the messaging, but risks leaving the directory behind. - Leaving the directory behind, however, is what is already happening - The fix for pypa#7479 gives the Virus scanner more time to finish its work, but there is still a possibility for a race condition that leaves the impression that there is an error in pip itself.
added 3 commits
January 2, 2020 13:08
- IOError persists as an issue in Python 2.7.17 on win32
|
Note - I have installed Python2.7 (again, though I was done with that), and I'm trying to reproduce this locally in my environment. |
|
I think the appveyor test is stuck. Will retry in a new pull-request. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix includes following work:
tests/lib/filesystem.pywhich opens a file in an external sub-process and holds it open. This is designed to be usable as either a context opener or a fixture, if so wired, and the open of the file is deferred in order to create just such race conditions as [WinError 5] Access is denied during cleanup/rmtree #7280tests/unit/test_utils_fileystem.pypip/_internal/temp_dir.pyis patched to convert an EACCES exception on Windows to a warning, and raise in other cases.tests/unit/tests_utils_temp_dir.pyis updated to test this functionality.