Skip to content

Mitigate Windows test failures due to PAX-format wheel release #7672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

chrahunt
Copy link
Member

#7668 should solve this, but it needs more attention. In the meantime to unblock existing PRs we can skip the relevant tests on Windows on Python 2.

Fixes #7671.

@chrahunt chrahunt added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 29, 2020
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on board.

@ncoghlan
Copy link
Member

The non-Windows CI runs in a UTF-8 based locale, so +1 from me.

@chrahunt chrahunt marked this pull request as ready for review January 29, 2020 22:43
@chrahunt chrahunt merged commit ace7d09 into pypa:master Jan 29, 2020
@chrahunt chrahunt deleted the maint/mitigate-failing-tests branch January 29, 2020 22:43
@chrahunt
Copy link
Member Author

Thank you both

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Feb 29, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows CI is currently broken for Python 2.7
3 participants