Skip to content

Cleanup WheelCache cleanup #7697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chrahunt
Copy link
Member

@chrahunt chrahunt commented Feb 5, 2020

This is just a minor cleanup enabled by the work in #7677.

Instead of explicitly cleaning up the temporary directory associated with our wheel cache, we manage it globally so it is cleaned up after our normal processing.

@chrahunt chrahunt added type: refactor Refactoring code skip news Does not need a NEWS file entry (eg: trivial changes) labels Feb 5, 2020
@chrahunt chrahunt marked this pull request as ready for review February 5, 2020 04:44
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best title.

@xavfernandez xavfernandez merged commit f97e88f into pypa:master Feb 5, 2020
@chrahunt chrahunt deleted the refactor/cleanup-wheel-cache-cleanup branch February 6, 2020 01:13
@chrahunt
Copy link
Member Author

chrahunt commented Feb 6, 2020

Thank you

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Mar 10, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants