New resolver: Carry extras info in ExplicitRequirement #8146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
the
skip news
pfmoore
requested changes
Apr 26, 2020
Local source directory is still not working due to some other reasons. Need to investigate.
uranusjr
force-pushed
the
new-resolver-extra-in-explicit-requirement
branch
from
5175931 to
06d9ea0
Compare
pfmoore
approved these changes
Apr 27, 2020
|
I opened #8150 |
|
YAY! This passes the corresponding YAML test: https://travis-ci.org/github/pypa/pip/jobs/679956068#L1638 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7714 (comment)
The main problem is that we forgot to pass the extras when building an ExplicitRequirement, so the info get lost.
The fix led me to another issue that we were not building the non-extras requirement correctly in
get_dependencies(). The previous implementation always builds a SpecifierRequirement, which is not correct. The fix simply delegates the logic tofactory.make_requirement_from_install_req()which chooses the correct class automatically.