Revise method fetching metadata using lazy wheels #8710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
reviewed
Aug 5, 2020
McSinyx
force-pushed
the
unnest-lazy-fetch
branch
3 times, most recently
from
bba9b7f to
314973e
Compare
* Rename it to fit the fact that it no longer handle fetching _not_ using lazy wheels * Use self as the first parameter * Unnest the checks with additional logs showing reason when lazy wheel is not used
McSinyx
force-pushed
the
unnest-lazy-fetch
branch
from
314973e to
11f7994
Compare
chrahunt
approved these changes
Aug 6, 2020
pradyunsg
approved these changes
Aug 6, 2020
|
Thanks for the reviews and merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #8685 (comment)