Check in work to make safety a module. #6365
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Pipenv!
Make safety an optional dependency via extras
Problem
Currently, pipenv vendors the safety package and its dependencies directly in the
pipenv/patched/
directory. This approach has several drawbacks:Solution
This PR makes safety an optional dependency via extras:
pipenv/patched/
pipenv[safety]
)Implementation Details
safety>=3.0.0
andtyper>=0.9.0
as optional dependencies underoptional-dependencies.safety
in pyproject.tomlTesting
To test this change:
pipenv check
without safety installed - it should prompt to install safetypipenv check
again to verify it works with the installed safetypip install pipenv[safety]
and verify check works without promptingImpact
The checklist
news/
directory to describe this fix with the extension.bugfix.rst
,.feature.rst
,.behavior.rst
,.doc.rst
..vendor.rst
. or.trivial.rst
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.