Fixes for ruff rule PLW1508 #6367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cclauss
commented
Mar 21, 2025
pipenv/utils/pip.py
Outdated
| return [] | ||
| if pip_trusted_hosts := os.environ.get("PIP_TRUSTED_HOSTS"): | ||
| return pip_trusted_hosts.split(" ") | ||
| return [] |
There was a problem hiding this comment.
.split(" ") seems far more dangerous than .split() in the instance of multiple contiguous spaces or other whitespace like tab-separated data so an alternative might be:
return os.environ.get("PIP_TRUSTED_HOSTS", "").split()
There was a problem hiding this comment.
Thats fine -- we want to make it the best it can be -- I tried here but has the same issue you are pointing out: https://github.com/pypa/pipenv/pull/6360/files#diff-827e674fd6d9a49bf96cdf22a01b6423dd7e92214db5836658108c4e35fa53d0L146-L150
I can rebase to what you determine is best.
There was a problem hiding this comment.
I do not have merge rights so please merge or close as you see fit.
cclauss
commented
Mar 21, 2025
cclauss
force-pushed
the
fix-for-ruff-rule-PLW1508
branch
from
9905520 to
1efaf48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Pipenv!
The issue
#6339 failed to merge cleanly so this pull request fixes to violations of ruff rule PLW1508.
What is the thing you want to fix? Is it associated with an issue on GitHub? Please mention it.
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.