Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary safety #6369

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Binary safety #6369

wants to merge 4 commits into from

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Mar 30, 2025

Since safety now requires a login and it's breaking the API we used, we can move it to a "plugin" we install.
This PR isn't adding a new scan command. Instead for pipenv users it keeps the "check" interface, but under the hood,
it will call the new scan command.
The new scan command understands Pipefile.lock, so there is no need to export to requirements.txt before scanning.
Hence, it directly reads it. Also, the scan command will only work if the user will configure ~/.safety/auth.ini.
Also, it does not parse safety output, instead it delivers it as is.

The PR is quite radical and is breaking a lot of things at once,

@oz123 oz123 requested a review from matteius March 30, 2025 21:39
@matteius
Copy link
Member

I recommend keeping the check command intact as it was since it still works with the existing database, and support the scan command as an optional flag or via pipenv scan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants