fix possible issue with transitive build dependencies #1922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case where a missing transitive build dependency is required by an extra for an already installed build dependency.
Example:
setup.py
containing:setup_requires=['dep[extra]']
dep
is already installed, and the dependencies forextra
are:['extra_dep']
extra_dep
is not already installed, andfetch_build_egg('extra_dep; extra =="extra"')
is calledIf the marker is not stripped,
pip wheel [...] 'extra_dep; extra =="extra"'
ignores the requirement, and does not build a wheel, but still returns with no error.Summary of changes
Closes the second issue found in #1920.
Pull Request Checklist