Remove 'dry run' functionality throughout. #4872
Open
+249
−409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
commented
Mar 9, 2025
Avasam
reviewed
Mar 11, 2025
jaraco
force-pushed
the
debt/dry-run
branch
2 times, most recently
from
bfb58ac to
0ac9dba
Compare
|
@abravalheri Any reservations before I proceed with merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
At first, I considered deprecating this functionality. Then I realized that this functionality is exposed almost exclusively through a parameter to
setup.py, which is already deprecated. Moreover, it seems unlikely that anyone would use this functionality in today's modern usage. I personally haven't used it even going back to the most legacy usage.Removing these changes from Setuptools should unblock the failing tests in pypa/distutils#335, and in fact, maybe they should be merged together for easier rollback if needed. [Update] The changes from pypa/distutils#335 are included in this merge.
Ref pypa/distutils#334
Pull Request Checklist
newsfragments/.(See documentation for details)