Skip to content

test_simple: fix accidentally skipped test #16777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

woodruffw
Copy link
Member

This moves _update_context below test_with_files_quarantined_omitted_from_index and into a proper indentation, unskipping test_with_files_quarantined_omitted_from_index in the progress. I'm a little surprised test_with_files_quarantined_omitted_from_index's skippage wasn't caught by any dead code/unreachability checks 🤔

To get test_with_files_quarantined_omitted_from_index passing, I cargo-culted changed based on the other test changes made in #15716.

CC @ewdurbin @cofiem

See #15716 (review)

@woodruffw woodruffw requested a review from a team as a code owner September 23, 2024 16:04
@woodruffw woodruffw added the testing Test infrastructure and individual tests label Sep 23, 2024
@woodruffw woodruffw self-assigned this Sep 23, 2024
@di di enabled auto-merge (squash) September 23, 2024 16:09
@di di merged commit 0d7cb20 into pypi:main Sep 23, 2024
18 checks passed
@miketheman
Copy link
Member

I'm a little surprised test_with_files_quarantined_omitted_from_index's skippage wasn't caught by any dead code/unreachability checks

We don't currently report on coverage of the tests/ folder, as that would fail our checks today - there's a bunch of LOC in the test/fixtures that don't get reported as covered.

Apply this diff and run make tests to see:

diff --git a/pyproject.toml b/pyproject.toml
index e44f6a68e..c07d3cbaf 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,7 +1,7 @@
 [tool.coverage.run]
 branch = true
 dynamic_context = "test_function"
-source = ["warehouse"]
+source = ["warehouse", "tests"]
 omit = [
   # We don't want to get coverage information for our migrations.
   "warehouse/migrations/*",

It's probably worth trying to burn down those instances, so we can apply this diff and ensure that every line of code in the tests/ folder gets executed during a test suite run.

@miketheman miketheman deleted the ww/fix-helper branch September 23, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Test infrastructure and individual tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants