Skip to content

DOC: add note for WKT and CRS interaction #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

myl-dvl
Copy link
Contributor

@myl-dvl myl-dvl commented Apr 25, 2025

image


It seems that it added my previous commits, I'm not sure what I did wrong.
Does it change anything for the PR ?

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (6a38287) to head (8ff8133).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
+ Coverage   96.50%   96.56%   +0.05%     
==========================================
  Files          20       20              
  Lines        1830     1832       +2     
==========================================
+ Hits         1766     1769       +3     
+ Misses         64       63       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snowman2
Copy link
Member

Probably helpful to note here that WKT doesn't work on import for CoordinateSystem and PROJ JSON is preferred:

- WKT string

@myl-dvl
Copy link
Contributor Author

myl-dvl commented Apr 27, 2025

Probably helpful to note here that WKT doesn't work on import for CoordinateSystem and PROJ JSON is preferred:

- WKT string


Something like this ?

image

@snowman2
Copy link
Member

Something like this ?

Yes, that would be great to add to from_user_input.

@myl-dvl
Copy link
Contributor Author

myl-dvl commented May 3, 2025

Something like this ?

Yes, that would be great to add to from_user_input.

I'm not sure if you want the note here or in this method (link).
Could you elaborate please ?
I will undraft this PR, if by luck it works for you^^

@myl-dvl myl-dvl marked this pull request as ready for review May 3, 2025 17:58
@snowman2
Copy link
Member

snowman2 commented May 5, 2025

The original issue #1485 had confusion as the user was using from_user_input. So, I think that it would be good to ensure that we add a note inside that method. You can also have a note where you have it as well as someone may see it there instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: WKT & coordinate systems not compatible as standalone element
2 participants