This repository was archived by the owner on Mar 15, 2022. It is now read-only.
Update wheel version installed for PyPy >= 7.3.0 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
reviewed
Feb 13, 2020
mattip
reviewed
Feb 13, 2020
| local exe=$1 | ||
| $exe -c 'import sys; print("requirements-pre-7.3.0.txt" if sys.pypy_version_info < (7,3,0) else "requirements.txt")' | ||
| } | ||
|
|
There was a problem hiding this comment.
This is correct since pypy < 7.3 does not properly support pip>20 and wheel>0.34
There was a problem hiding this comment.
Just for the record: I think I actually tried this installing pip 20 and wheel 0.34, and it seemed to work? (Except that the old directory symlinks got overwritten, since pp27-pypy_41 is ambiguous, being the new-style tag for both 7.1.x and 7.2.x.)
|
@antocuni any thoughts? |
looks good to me |
|
We should update the ensurepip versions of pip and setuptools to get the post-pip20 python tags by default |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to (finally) complete pypa/cibuildwheel#185, we need an up-to-date version of wheel (>= 0.34) after pypa/cibuildwheel#156 was merged.
However, wheel>=0.34 also defines new Python version tags for PyPy, resulting in different wheel filenames. As such, an update of the manylinux2010 image to use the new tags seems appropriate.
The updates of these packages in the base PyPA manylinux images are blocked on the matter of dropping Python 3.4 (and perhaps 2.7).
Note that the symlinks in
/opt/pythonfor PyPy 7.3.0 are changed by this PR. Alternatively, I thought of creating the old symlinks next to the new ones (i.e.,/opt/python/pp273-pypy_73as well as/opt/python/pp27-pypy_73) to ensure backwards compatibility. But this would cause users looping over all folders in/opt/pythonto encounter the same version twice.(If merging this PR before pypa/manylinux gets updated is considered to be too early, a workaround should be possible in
cibuildwheelto still updatewheelmanually, so I do not think we depend on this very critically.)